replace set with addFields in aggregations py #3111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR replaces the aggregation stage
$set
operator with the$addFields
operator inaggregations.py
. These two operators are alias to each other in MongoDB. The reason for the change is$addFields
is supported by AWS DocumentDB while$set
is not.Note the $set operator is overloaded in MongoDB, and the one under change is the aggregation stage $set operator as opposed to the update operator $set.
After this PR is approved, follow up PRs will be submitted to replace all the
$set
aggregation operators to$addFields
across the codebase to keep things consistent.How is this patch tested? If it is not, please explain why.
pytest tests/unittests
all green.No new tests are added as this is effectively a cosmetic change.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes