Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing merge_samples() for video datasets #3159

Merged
merged 2 commits into from Jun 5, 2023
Merged

Fixing merge_samples() for video datasets #3159

merged 2 commits into from Jun 5, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jun 3, 2023

Resolves #3158

@brimoor brimoor added the bug Bug fixes label Jun 3, 2023
@brimoor brimoor requested a review from a team June 3, 2023 15:36
@brimoor brimoor self-assigned this Jun 3, 2023
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9038b31) 49.22% compared to head (599bca1) 49.22%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3159   +/-   ##
========================================
  Coverage    49.22%   49.22%           
========================================
  Files          230      230           
  Lines        34446    34446           
  Branches       325      325           
========================================
  Hits         16957    16957           
  Misses       17489    17489           
Flag Coverage Δ
app 49.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit 1ef3e27 into develop Jun 5, 2023
10 of 11 checks passed
@brimoor brimoor deleted the bugfix/iss-3158 branch June 5, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] merge_samples() fails on video datasets
2 participants