Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown table support #3162

Merged
merged 1 commit into from Jun 7, 2023
Merged

markdown table support #3162

merged 1 commit into from Jun 7, 2023

Conversation

ritch
Copy link
Contributor

@ritch ritch commented Jun 5, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 5.12% and project coverage change: -0.03 ⚠️

Comparison is base (7d769e4) 49.25% compared to head (0307bca) 49.22%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3162      +/-   ##
===========================================
- Coverage    49.25%   49.22%   -0.03%     
===========================================
  Files          230      230              
  Lines        34424    34446      +22     
  Branches       325      325              
===========================================
+ Hits         16956    16957       +1     
- Misses       17468    17489      +21     
Flag Coverage Δ
app 49.22% <5.12%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponents/src/components/PillButton/PillButton.tsx 52.27% <0.00%> (-1.22%) ⬇️
...ages/components/src/components/Results/Results.tsx 29.52% <0.00%> (-0.29%) ⬇️
.../components/src/components/TabOption/TabOption.tsx 45.79% <0.00%> (-0.44%) ⬇️
...ages/components/src/components/Tooltip/Tooltip.tsx 23.61% <0.00%> (-0.34%) ⬇️
...es/components/src/components/Selector/Selector.tsx 21.57% <5.26%> (-0.37%) ⬇️
app/packages/looker/src/elements/common/tags.ts 14.89% <7.14%> (-0.18%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritch ritch merged commit e4aa0aa into develop Jun 7, 2023
12 of 15 checks passed
@ritch ritch deleted the use-remark-gfm branch June 7, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants