Add sample tags to colorScheme editor #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzhenw
added
feature
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3171 +/- ##
===========================================
- Coverage 49.25% 49.20% -0.06%
===========================================
Files 230 230
Lines 34424 34464 +40
Branches 325 325
===========================================
+ Hits 16956 16957 +1
- Misses 17468 17507 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
benjaminpkane
added a commit
that referenced
this pull request
Jun 12, 2023
* allow sample tag color to be customized * address PR --------- Co-authored-by: Lanny W <lanzhenwang9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Added sample tags to colorScheme editor. User can now configure sample tags like other common ListField.
How is this patch tested? If it is not, please explain why.
Screen.Recording.2023-06-07.at.8.37.44.AM.mov
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyonePython library changes