Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups / dynamic groups bug fixes, fix e2e #3172

Merged
merged 16 commits into from Jun 8, 2023

Conversation

sashankaryal
Copy link
Contributor

@sashankaryal sashankaryal commented Jun 7, 2023

What changes are proposed in this pull request?

  • fix dynamic groups not working with pointcloud slices
  • hide groups statistics selector when dynamic groups is on
  • fix bug where 3d projected labels weren't showing when no orthographic projection was available
  • add regression tests
  • improve e2e
    • install requirements to fix issue that was causing tests to fail because of missing deps
    • catch rare and random known exceptions to reduce test flakiness
    • make sure screenshots are always uploaded (previously was only uploaded on test success)

How is this patch tested? If it is not, please explain why.

  • locally, all e2e tests green

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@sashankaryal sashankaryal self-assigned this Jun 7, 2023
@sashankaryal sashankaryal requested a review from a team June 7, 2023 16:54
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (bf131b1) 49.22% compared to head (19b434f) 49.18%.

❗ Current head 19b434f differs from pull request most recent head f8e955f. Consider uploading reports for the commit f8e955f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3172      +/-   ##
===========================================
- Coverage    49.22%   49.18%   -0.05%     
===========================================
  Files          230      230              
  Lines        34446    34478      +32     
  Branches       325      325              
===========================================
  Hits         16957    16957              
- Misses       17489    17521      +32     
Flag Coverage Δ
app 49.18% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/looker/src/elements/pcd.ts 13.11% <0.00%> (-1.98%) ⬇️
app/packages/state/src/recoil/groups.ts 46.00% <0.00%> (-0.63%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sashankaryal sashankaryal force-pushed the refactor/dynamic-groups-pagination-ui branch from ab987ba to 5fd0ac3 Compare June 7, 2023 23:28
@sashankaryal sashankaryal force-pushed the refactor/dynamic-groups-pagination-ui branch from cbc58ca to 4eec477 Compare June 8, 2023 15:37
@sashankaryal sashankaryal changed the title groups / dynamic groups bug fixes groups / dynamic groups bug fixes, fix 2e2 Jun 8, 2023
@sashankaryal sashankaryal changed the title groups / dynamic groups bug fixes, fix 2e2 groups / dynamic groups bug fixes, fix e2e Jun 8, 2023
context("unordered", () => {
it("should create dynamic groups based on scene_id", () => {
cy.get("[data-cy=entry-counts").should("have.text", "200 groups");
["left", "right", "pcd"].forEach((slice) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 cool

@sashankaryal sashankaryal requested a review from ritch June 8, 2023 19:49
@sashankaryal sashankaryal merged commit 6814863 into develop Jun 8, 2023
12 of 13 checks passed
@sashankaryal sashankaryal deleted the refactor/dynamic-groups-pagination-ui branch June 8, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants