Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --all flags to plugin CLI methods #3177

Merged
merged 1 commit into from Jun 12, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jun 8, 2023

No description provided.

@brimoor brimoor added the enhancement Code enhancement label Jun 8, 2023
@brimoor brimoor requested a review from a team June 8, 2023 18:45
@brimoor brimoor self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 13.04% and project coverage change: -0.03 ⚠️

Comparison is base (7c00686) 49.22% compared to head (0c5537e) 49.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3177      +/-   ##
===========================================
- Coverage    49.22%   49.20%   -0.03%     
===========================================
  Files          230      230              
  Lines        34446    34464      +18     
  Branches       325      325              
===========================================
  Hits         16957    16957              
- Misses       17489    17507      +18     
Flag Coverage Δ
app 49.20% <13.04%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/looker/src/elements/common/tags.ts 14.67% <0.00%> (-0.22%) ⬇️
app/packages/looker/src/elements/common/util.ts 23.64% <21.42%> (-1.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor changed the base branch from develop to release/v0.21.1 June 12, 2023 00:57
@brimoor brimoor merged commit 34b0899 into release/v0.21.1 Jun 12, 2023
6 of 7 checks passed
@brimoor brimoor deleted the feature/plugins-all branch June 12, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants