Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve saved views when serializing datasets #3231

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

benjaminpkane
Copy link
Contributor

Fixes the /sort route and other occurrences of serializing a dataset outside of graphql

@benjaminpkane benjaminpkane self-assigned this Jun 27, 2023
@benjaminpkane benjaminpkane changed the base branch from develop to release/v0.21.1 June 27, 2023 15:35
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 17.75% and project coverage change: +0.02 🎉

Comparison is base (30dbdf4) 15.13% compared to head (fffccd5) 15.15%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.21.1    #3231      +/-   ##
===================================================
+ Coverage            15.13%   15.15%   +0.02%     
===================================================
  Files                  562      563       +1     
  Lines                69022    68972      -50     
  Branches               599      600       +1     
===================================================
+ Hits                 10448    10455       +7     
+ Misses               58574    58517      -57     
Flag Coverage Δ
app 15.15% <17.75%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/.eslintrc.js 0.00% <0.00%> (ø)
app/packages/core/src/Root/Root.tsx 0.00% <0.00%> (ø)
.../packages/core/src/components/Actions/Selected.tsx 0.00% <0.00%> (ø)
...kages/core/src/components/Actions/similar/utils.ts 0.00% <0.00%> (ø)
app/packages/core/src/components/Grid/Grid.tsx 0.00% <0.00%> (ø)
.../DynamicGroup/NestedGroup/GroupElementsLinkBar.tsx 0.00% <0.00%> (ø)
...oup/NestedGroup/PaginationComponentWithTooltip.tsx 0.00% <0.00%> (ø)
...nts/Modal/Group/DynamicGroup/NestedGroup/index.tsx 0.00% <0.00%> (ø)
...Modal/Group/DynamicGroup/UnorderedDynamicGroup.tsx 0.00% <0.00%> (ø)
...cGroup/carousel/DynamicGroupsFlashlightWrapper.tsx 0.00% <0.00%> (ø)
... and 48 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@manivoxel51 manivoxel51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🍨

@benjaminpkane benjaminpkane merged commit 24c1f20 into release/v0.21.1 Jun 27, 2023
16 of 17 checks passed
@benjaminpkane benjaminpkane deleted the sort-saved-views branch June 27, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants