Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label conversion bugfix/tests #3293

Merged
merged 2 commits into from Jul 13, 2023
Merged

Label conversion bugfix/tests #3293

merged 2 commits into from Jul 13, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jul 13, 2023

Fixes a bug when passing an RGB hex string to Detection.to_segmentation(target=...).

Also adds some unit tests for Detection <> Polyline <> Segmentation conversions.

@brimoor brimoor added the bug Bug fixes label Jul 13, 2023
@brimoor brimoor requested a review from a team July 13, 2023 03:16
@brimoor brimoor self-assigned this Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2938588) 15.56% compared to head (d0c3dff) 15.56%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3293   +/-   ##
========================================
  Coverage    15.56%   15.56%           
========================================
  Files          564      564           
  Lines        69319    69319           
  Branches       681      681           
========================================
  Hits         10791    10791           
  Misses       58528    58528           
Flag Coverage Δ
app 15.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit 67f3fc7 into develop Jul 13, 2023
10 of 11 checks passed
@brimoor brimoor deleted the bugfix/to-segmentation branch July 13, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants