Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve errors with Labelbox integration #3323

Merged
merged 3 commits into from Jul 25, 2023

Conversation

ehofesmann
Copy link
Member

@ehofesmann ehofesmann commented Jul 20, 2023

Labelbox has now fully deprecated "Queue mode" in favor of "batch mode". Previously, attempting to use the Labelbox integration would result in an error, this PR updates the integration to use batch mode and brings the integration back to its previous state.

Resolves #2654

@ehofesmann ehofesmann requested a review from a team July 20, 2023 23:22
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/v0.21.5@26dc961). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.21.5    #3323   +/-   ##
==================================================
  Coverage                   ?   15.54%           
==================================================
  Files                      ?      565           
  Lines                      ?    69518           
  Branches                   ?      682           
==================================================
  Hits                       ?    10804           
  Misses                     ?    58714           
  Partials                   ?        0           
Flag Coverage Δ
app 15.54% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehofesmann ehofesmann self-assigned this Jul 20, 2023
@ehofesmann ehofesmann added bug Bug fixes annotation Issues related to FiftyOne's annotation API labels Jul 20, 2023
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching! ⚒️🏅

fiftyone/utils/labelbox.py Outdated Show resolved Hide resolved
@ehofesmann ehofesmann merged commit ba3efa9 into release/v0.21.5 Jul 25, 2023
11 checks passed
@ehofesmann ehofesmann deleted the bug/labelbox-batch-mode branch July 25, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation Issues related to FiftyOne's annotation API bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants