Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure has_field() supports dynamic fields #3349

Merged
merged 2 commits into from Jul 27, 2023
Merged

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jul 27, 2023

Resolves #3346

@brimoor brimoor added the bug Bug fixes label Jul 27, 2023
@brimoor brimoor requested a review from a team July 27, 2023 04:40
@brimoor brimoor self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 14.84% and project coverage change: +15.50% 🎉

Comparison is base (e818463) 0.00% compared to head (eef0654) 15.50%.
Report is 55 commits behind head on release/v0.21.5.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/v0.21.5    #3349       +/-   ##
====================================================
+ Coverage                 0   15.50%   +15.50%     
====================================================
  Files                    0      569      +569     
  Lines                    0    70374    +70374     
  Branches                 0      687      +687     
====================================================
+ Hits                     0    10908    +10908     
- Misses                   0    59466    +59466     
Flag Coverage Δ
app 15.50% <14.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ackages/core/src/components/Actions/ActionsRow.tsx 0.00% <0.00%> (ø)
...p/packages/core/src/components/Common/Checkbox.tsx 0.00% <0.00%> (ø)
...core/src/components/Filters/NumericFieldFilter.tsx 0.00% <0.00%> (ø)
...ts/Filters/categoricalFilter/CategoricalFilter.tsx 0.00% <0.00%> (ø)
...ents/Filters/categoricalFilter/ResultComponent.tsx 0.00% <0.00%> (ø)
...c/components/Filters/categoricalFilter/Wrapper.tsx 0.00% <0.00%> (ø)
...ters/categoricalFilter/filterOption/FilterItem.tsx 0.00% <0.00%> (ø)
...rs/categoricalFilter/filterOption/FilterOption.tsx 0.00% <0.00%> (ø)
...ages/core/src/components/Schema/SchemaSettings.tsx 0.00% <0.00%> (ø)
...ore/src/components/Sidebar/Entries/FilterEntry.tsx 0.00% <0.00%> (ø)
... and 26 more

... and 533 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and seems to work as advertised!
Just one minor comment

fiftyone/core/odm/document.py Outdated Show resolved Hide resolved
Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brimoor brimoor merged commit 85f055c into release/v0.21.5 Jul 27, 2023
9 of 10 checks passed
@brimoor brimoor deleted the bug/iss-3346 branch July 27, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants