Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embeddings #3401

Merged
merged 2 commits into from Aug 7, 2023
Merged

Fix embeddings #3401

merged 2 commits into from Aug 7, 2023

Conversation

benjaminpkane
Copy link
Contributor

Update embeddings colormap recoil state

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 21.36% and project coverage change: +0.61% 🎉

Comparison is base (0572698) 15.42% compared to head (89cc7da) 16.03%.
Report is 352 commits behind head on main.

❗ Current head 89cc7da differs from pull request most recent head cdf7b91. Consider uploading reports for the commit cdf7b91 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3401      +/-   ##
==========================================
+ Coverage   15.42%   16.03%   +0.61%     
==========================================
  Files         564      571       +7     
  Lines       69626    70999    +1373     
  Branches      667      799     +132     
==========================================
+ Hits        10739    11384     +645     
- Misses      58887    59615     +728     
Flag Coverage Δ
app 16.03% <21.36%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/packages/app/src/index.tsx 0.00% <0.00%> (ø)
...nts/src/components/ErrorBoundary/ErrorBoundary.tsx 30.30% <0.00%> (-0.71%) ⬇️
app/packages/core/src/Dataset.ts 0.00% <0.00%> (ø)
...ackages/core/src/components/Actions/ActionsRow.tsx 0.00% <0.00%> (ø)
...kages/core/src/components/Actions/DynamicGroup.tsx 0.00% <0.00%> (ø)
...core/src/components/Actions/DynamicGroupAction.tsx 0.00% <0.00%> (ø)
...mponents/Actions/GroupMediaVisibilityContainer.tsx 0.00% <0.00%> (ø)
...p/packages/core/src/components/Actions/Options.tsx 0.00% <0.00%> (ø)
...p/packages/core/src/components/Actions/Patcher.tsx 0.00% <0.00%> (ø)
...pp/packages/core/src/components/Actions/Popout.tsx 0.00% <0.00%> (ø)
... and 136 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@findtopher findtopher changed the base branch from main to release/v0.21.6 August 7, 2023 16:44
@benjaminpkane benjaminpkane marked this pull request as ready for review August 7, 2023 16:58
@benjaminpkane benjaminpkane merged commit 02d425c into release/v0.21.6 Aug 7, 2023
13 checks passed
@benjaminpkane benjaminpkane deleted the bug/color-map branch August 7, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants