Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dataset tag and label filters when exporting a dataset from cli #3412

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

Rusteam
Copy link
Contributor

@Rusteam Rusteam commented Aug 15, 2023

What changes are proposed in this pull request?

When running fiftyone datasets export ... from cli, dataset filters can be provided in order to export only a subset.

How is this patch tested? If it is not, please explain why.

Running from cli to test it:

alias fod="fiftyone datasets"

fod export quickstart -d tmp -t fiftyone.types.ImageDirectory --filters tags=test
fod export quickstart -d tmp -t fiftyone.types.ImageDirectory --filters ground_truth=kite,bird,airplane

The output should only contain a subset that matches this sample tag and labels.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

Fiftyone cli dataset export now supports sample tag and label filters in order to export only a subset.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rusteam! I think this is a useful addition

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7239383) 16.03% compared to head (2309cce) 16.03%.
Report is 52 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3412   +/-   ##
========================================
  Coverage    16.03%   16.03%           
========================================
  Files          571      571           
  Lines        71014    71014           
  Branches       799      799           
========================================
  Hits         11384    11384           
  Misses       59630    59630           
Flag Coverage Δ
app 16.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminpkane benjaminpkane merged commit daca7fa into voxel51:develop Aug 17, 2023
10 of 11 checks passed
@Rusteam Rusteam deleted the dataset-export-filters branch August 18, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants