Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets to plugins #3453

Merged
merged 5 commits into from Aug 28, 2023
Merged

Add secrets to plugins #3453

merged 5 commits into from Aug 28, 2023

Conversation

kaixi-wang
Copy link
Contributor

What changes are proposed in this pull request?

(Please fill in changes proposed in this fix)

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@kaixi-wang kaixi-wang self-assigned this Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ffccbc) 15.98% compared to head (0828382) 15.98%.
Report is 10 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3453   +/-   ##
========================================
  Coverage    15.98%   15.98%           
========================================
  Files          572      572           
  Lines        71235    71235           
  Branches       800      800           
========================================
  Hits         11388    11388           
  Misses       59847    59847           
Flag Coverage Δ
app 15.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

use to_dict() rather than builtin __dict__ to prevent serializing internal properties
@kaixi-wang kaixi-wang changed the title [WIP] add secrets to plugins Add secrets to plugins Aug 28, 2023
@kaixi-wang kaixi-wang merged commit c0e2d57 into develop Aug 28, 2023
11 checks passed
@kaixi-wang kaixi-wang deleted the kacey/oss-secrets branch August 28, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants