Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The default
lineJoin
algorithm ismiter
, which extends the two lines to meet at a point called the "miter point". AmiterLimit
parameter is used to control how far the miter point can extend before it's beveled to prevent overly long, sharp corners. ReducingmiterLimit
to a low value like1
made the corners look significantly better, but they were still not completely gone.bevel
, which creates a more rounded corner by adding a diagonal line between the endpoints of the connected lines, is a nice compromise betweenmiter
andround
.(link to w3 playground for
lineJoin
)Before
After
How is this patch tested? If it is not, please explain why.
Visually, locally
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes