Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix polyline rendering artifact #3476

Merged
merged 1 commit into from Aug 31, 2023
Merged

Conversation

sashankaryal
Copy link
Contributor

@sashankaryal sashankaryal commented Aug 31, 2023

What changes are proposed in this pull request?

The default lineJoin algorithm is miter, which extends the two lines to meet at a point called the "miter point". A miterLimit parameter is used to control how far the miter point can extend before it's beveled to prevent overly long, sharp corners. Reducing miterLimit to a low value like 1 made the corners look significantly better, but they were still not completely gone. bevel, which creates a more rounded corner by adding a diagonal line between the endpoints of the connected lines, is a nice compromise between miter and round.

(link to w3 playground for lineJoin)

Before

Screenshot 2023-08-31 at 4 24 00 PM Screenshot 2023-08-31 at 4 23 39 PM

After

Screenshot 2023-08-31 at 4 24 40 PM Screenshot 2023-08-31 at 4 24 50 PM

How is this patch tested? If it is not, please explain why.

Visually, locally

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@sashankaryal sashankaryal self-assigned this Aug 31, 2023
@sashankaryal sashankaryal requested a review from a team August 31, 2023 21:30
@sashankaryal sashankaryal changed the title fix polyline artifact because of line join fix polyline rendering artifact Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (2f01d9c) 15.98% compared to head (617b961) 15.98%.
Report is 11 commits behind head on release/v0.22.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.22.0    #3476      +/-   ##
===================================================
- Coverage            15.98%   15.98%   -0.01%     
===================================================
  Files                  573      573              
  Lines                71297    71298       +1     
  Branches               800      800              
===================================================
  Hits                 11400    11400              
- Misses               59897    59898       +1     
Flag Coverage Δ
app 15.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/packages/looker/src/lookers/abstract.ts 9.54% <0.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎨

@sashankaryal sashankaryal merged commit a83f74b into release/v0.22.0 Aug 31, 2023
13 of 15 checks passed
@sashankaryal sashankaryal deleted the bug/vertices-artifact branch August 31, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants