Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to filepath if grid_media_field is undefined for the current view #3498

Merged
merged 6 commits into from Sep 9, 2023

Conversation

manivoxel51
Copy link
Contributor

@manivoxel51 manivoxel51 commented Sep 8, 2023

(Please fill in changes proposed in this fix)

  • fix
  • unittest

to reproduce

Screen.Recording.2023-09-08.at.2.00.56.PM.mov

After fix

Screen.Recording.2023-09-08.at.2.00.21.PM.mov

huge thanks to Ben for help! 🍨

Unit test

Screen.Recording.2023-09-08.at.2.47.52.PM.mov

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: +0.01% 🎉

Comparison is base (ee93587) 15.98% compared to head (c1992bb) 16.00%.
Report is 2 commits behind head on release/v0.22.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.22.0    #3498      +/-   ##
===================================================
+ Coverage            15.98%   16.00%   +0.01%     
===================================================
  Files                  573      573              
  Lines                71309    71326      +17     
  Branches               800      804       +4     
===================================================
+ Hits                 11401    11417      +16     
- Misses               59908    59909       +1     
Flag Coverage Δ
app 16.00% <81.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
app/packages/state/src/hooks/useStateUpdate.ts 25.67% <33.33%> (ø)
app/packages/state/src/recoil/options.ts 98.31% <89.47%> (-1.69%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manivoxel51 manivoxel51 changed the title [WIP] Fallback to filepath if grid_media_field is undefined for the current view Fallback to filepath if grid_media_field is undefined for the current view Sep 8, 2023
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Creating unit tests for these is a good call. I tweaked the implementation a little to use fieldPaths instead of the schema directly. This simplified mock data and makes the assertions more self-contained.

@manivoxel51 manivoxel51 merged commit 3da509e into release/v0.22.0 Sep 9, 2023
14 of 15 checks passed
@manivoxel51 manivoxel51 deleted the bug/media-type-fallback branch September 9, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants