Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize list datasets info #3528

Merged
merged 1 commit into from Sep 15, 2023
Merged

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Sep 15, 2023

No description provided.

@brimoor brimoor added the enhancement Code enhancement label Sep 15, 2023
@brimoor brimoor requested a review from a team September 15, 2023 13:54
@brimoor brimoor self-assigned this Sep 15, 2023
@brimoor brimoor changed the base branch from develop to release/v0.22.0 September 15, 2023 13:54
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (435c0c1) 15.85% compared to head (ac474d8) 15.84%.
Report is 3 commits behind head on release/v0.22.0.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.22.0    #3528      +/-   ##
===================================================
- Coverage            15.85%   15.84%   -0.01%     
===================================================
  Files                  593      593              
  Lines                72763    72768       +5     
  Branches               861      861              
===================================================
  Hits                 11533    11533              
- Misses               61230    61235       +5     
Flag Coverage Δ
app 15.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...core/src/plugins/SchemaIO/components/ErrorView.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swheaton
Copy link
Contributor

This is a lot faster especially in Teams through API. Was basically unusable before.
Do you think anyone relies on / would miss the num_samples part of the info?

@brimoor
Copy link
Contributor Author

brimoor commented Sep 15, 2023

@swheaton yeah not sure if anyone is relying on num_samples, but there'd be no way to get this information efficiently because it would require n API calls to get estimated counts, and the n API calls part is why the method was slow.

@swheaton
Copy link
Contributor

Right. A little better than loading every dataset completely (which is like n * 4 db calls), but still not ideal.

Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested and works well also

@brimoor brimoor merged commit c171270 into release/v0.22.0 Sep 15, 2023
15 of 17 checks passed
@brimoor brimoor deleted the optimize-list-datasets-info branch September 15, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants