Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MarkdownView, SwitchView, and Placement #3537

Merged
merged 1 commit into from Sep 18, 2023

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Sep 18, 2023

What changes are proposed in this pull request?

(Please fill in changes proposed in this fix)

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (83c1ebc) 15.84% compared to head (7ef5819) 15.84%.
Report is 36 commits behind head on release/v0.22.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.22.0    #3537   +/-   ##
================================================
  Coverage            15.84%   15.84%           
================================================
  Files                  593      593           
  Lines                72768    72767    -1     
  Branches               861      861           
================================================
  Hits                 11533    11533           
+ Misses               61235    61234    -1     
Flag Coverage Δ
app 15.84% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...e/src/plugins/SchemaIO/components/MarkdownView.tsx 0.00% <0.00%> (ø)
...ore/src/plugins/SchemaIO/components/SwitchView.tsx 0.00% <0.00%> (ø)
app/packages/operators/src/OperatorPlacements.tsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imanjra imanjra merged commit 825bda8 into release/v0.22.0 Sep 18, 2023
14 of 15 checks passed
@imanjra imanjra deleted the operators-im-x20 branch September 18, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants