Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for read-only mode in FileExplorerView #3597

Merged
merged 1 commit into from Sep 30, 2023

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Sep 29, 2023

What changes are proposed in this pull request?

When using the FileExplorerView with read_only flag, display value for the property as an read-only ObjectView as shown below:

image

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@imanjra imanjra requested a review from ritch September 29, 2023 15:16
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e77affa) 15.98% compared to head (6f91cbd) 15.98%.
Report is 1 commits behind head on release/v0.22.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.22.1    #3597   +/-   ##
================================================
  Coverage            15.98%   15.98%           
================================================
  Files                  594      594           
  Lines                72858    72855    -3     
  Branches               902      902           
================================================
  Hits                 11643    11643           
+ Misses               61215    61212    -3     
Flag Coverage Δ
app 15.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...emaIO/components/FileExplorerView/FileExplorer.tsx 0.00% <0.00%> (ø)
...O/components/FileExplorerView/FileExplorerView.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritch ritch merged commit aa4cd3f into release/v0.22.1 Sep 30, 2023
13 of 15 checks passed
@ritch ritch deleted the file-explorer-view-readonly branch September 30, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants