Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Boolean not displayed in modal view sidebar entry #3713

Merged
merged 1 commit into from Oct 23, 2023

Conversation

lanzhenw
Copy link
Contributor

@lanzhenw lanzhenw commented Oct 23, 2023

What changes are proposed in this pull request?

Bugfix: Boolean field are not displayed in the modal view. Looks like a regression typo.

How is this patch tested? If it is not, please explain why.

Screenshot 2023-10-22 at 10 14 41 PM

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@lanzhenw lanzhenw added the bug Bug fixes label Oct 23, 2023
@lanzhenw lanzhenw requested a review from a team October 23, 2023 03:18
@lanzhenw lanzhenw self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6b82c44) 16.21% compared to head (72b25bd) 16.21%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3713   +/-   ##
========================================
  Coverage    16.21%   16.21%           
========================================
  Files          640      640           
  Lines        74189    74189           
  Branches       988      988           
========================================
  Hits         12029    12029           
  Misses       62160    62160           
Flag Coverage Δ
app 16.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/packages/core/src/utils/generic.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@manivoxel51 manivoxel51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍨

@lanzhenw lanzhenw merged commit 70dc113 into develop Oct 23, 2023
13 checks passed
@lanzhenw lanzhenw deleted the bugfix/booleanValue branch October 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants