New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: refresh looker when media field changes #3735
bugfix: refresh looker when media field changes #3735
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.22.3 #3735 +/- ##
==================================================
Coverage ? 15.98%
==================================================
Files ? 596
Lines ? 73191
Branches ? 917
==================================================
Hits ? 11703
Misses ? 61488
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🖼️
One alternative that captures media field changes for all Looker
components is to include useRecoilValue(selectedMediaField(true))
as a dependency in the createLooker memo
Somehow missed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What changes are proposed in this pull request?
Fix bug where looker wasn't refreshing correctly when modal media field changed.
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes