fix sidebar re-arranging bug #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where sample tags entry jumps to moving group when placed above tags
manivoxel51
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
nice work! 🍨
did a quick test before and after your fix and looks good
before
Screen.Recording.2023-11-01.at.7.14.08.PM.mov
after - which seems to be locking the top tag group and stop the jump of sample tags field
Uploading Screen Recording 2023-11-01 at 7.13.39 PM.mov…
will defer to @benjaminpkane for final green light in case there are other side effects
benjaminpkane
approved these changes
Nov 1, 2023
kaixi-wang
pushed a commit
that referenced
this pull request
Nov 2, 2023
where sample tags entry jumps to moving group when placed above tags
kaixi-wang
pushed a commit
that referenced
this pull request
Nov 2, 2023
where sample tags entry jumps to moving group when placed above tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
fixed sidebar group re-arranging issue where sample tags jumps to the moving group when the moving group is taken above tags group
How is this patch tested? If it is not, please explain why.
By attempting to drag any of the group in sidebar above the sticky tags group
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
What areas of FiftyOne does this PR affect?
fiftyonePython library changes