Operator list is behind the modal #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashankaryal
approved these changes
Nov 2, 2023
| @@ -6,7 +6,7 @@ export const ModalWrapper = styled.div` | |||
| left: 0; | |||
| width: 100%; | |||
| height: 100%; | |||
| z-index: 100000000 !important; | |||
| z-index: 1000; // do not set more than 1300 (operator panel) | |||
There was a problem hiding this comment.
We should consider having one authoritative file that contains all z-index values. soon ™️
There was a problem hiding this comment.
Let's talk about this offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
fix the zIndex conflict between modals.
Operator List modal uses a z-index of 1300. I set the sample modal and color modal between 1300 to fix the problem.
How is this patch tested? If it is not, please explain why.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyonePython library changes