Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin secrets available in resolve_input #3759

Merged

Conversation

kaixi-wang
Copy link
Contributor

@kaixi-wang kaixi-wang commented Nov 1, 2023

What changes are proposed in this pull request?

Secrets should be available via ctx.secrets when resolve_input is called.

@kaixi-wang kaixi-wang self-assigned this Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (3c67a71) 15.99% compared to head (248f2e8) 15.97%.
Report is 9 commits behind head on release/v0.22.3.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.22.3    #3759      +/-   ##
===================================================
- Coverage            15.99%   15.97%   -0.02%     
===================================================
  Files                  596      597       +1     
  Lines                73188    73246      +58     
  Branches               917      918       +1     
===================================================
  Hits                 11703    11703              
- Misses               61485    61543      +58     
Flag Coverage Δ
app 15.97% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/packages/core/src/ga.ts 0.00% <0.00%> (ø)
app/packages/operators/src/OperatorCore.tsx 0.00% <0.00%> (ø)
app/packages/core/src/components/Modal/Looker.tsx 0.00% <0.00%> (ø)
...p/packages/core/src/components/Sidebar/Sidebar.tsx 0.00% <0.00%> (ø)
app/packages/core/src/Root/Root.tsx 0.00% <0.00%> (ø)
app/packages/operators/src/state.ts 0.00% <0.00%> (ø)
app/packages/operators/src/hooks.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaixi-wang kaixi-wang requested a review from a team November 1, 2023 22:05
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaixi-wang kaixi-wang merged commit 73088e1 into release/v0.22.3 Nov 2, 2023
9 of 11 checks passed
@kaixi-wang kaixi-wang deleted the kacey/release0.22.3/resolve-input-secrets branch November 2, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants