Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-default browser to launch the app #3789

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

Rusteam
Copy link
Contributor

@Rusteam Rusteam commented Nov 8, 2023

What changes are proposed in this pull request?

Fiftyone works best in Chrome, while users might prefer other browsers for surfing the internet.

Add a --browser <browser_name> parameter to fiftyone app launch to use a non-default browser to open the App.

How is this patch tested? If it is not, please explain why.

Running these commands:

fiftyone app launch -b chrome
fiftyone app launch --browser safari
fiftyone app launch --browser oper  # fails (no browser registered with this name)
 fiftyone app launch --browser opera  # fails (non-executable found)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

Launch the app in the non-default browser.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great addition. Looks like all the details are here 🙌

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 850 lines in your changes are missing coverage. Please review.

Comparison is base (14dfe52) 16.15% compared to head (47248fb) 16.23%.
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3789      +/-   ##
===========================================
+ Coverage    16.15%   16.23%   +0.08%     
===========================================
  Files          643      645       +2     
  Lines        74209    74683     +474     
  Branches       984      992       +8     
===========================================
+ Hits         11988    12125     +137     
- Misses       62221    62558     +337     
Flag Coverage Δ
app 16.23% <18.11%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
app/packages/looker/src/state.ts 100.00% <100.00%> (ø)
app/packages/looker/src/worker/index.ts 98.82% <100.00%> (+0.08%) ⬆️
...ackages/relay/src/fragments/colorSchemeFragment.ts 100.00% <100.00%> (ø)
...es/relay/src/fragments/datasetAppConfigFragment.ts 100.00% <100.00%> (ø)
app/packages/relay/src/queries/dataset.ts 100.00% <100.00%> (ø)
app/packages/state/src/session.ts 74.85% <100.00%> (+0.14%) ⬆️
app/packages/utilities/src/color.ts 51.18% <100.00%> (ø)
app/packages/utilities/src/index.ts 62.53% <100.00%> (+0.30%) ⬆️
...s/core/src/components/ColorModal/GlobalSetting.tsx 0.00% <0.00%> (ø)
...es/core/src/components/FieldLabelAndInfo/index.tsx 0.00% <0.00%> (ø)
... and 25 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminpkane benjaminpkane merged commit 66a0b98 into voxel51:develop Nov 8, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants