Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3763 #3816

Merged
merged 1 commit into from Nov 17, 2023
Merged

Fixes #3763 #3816

merged 1 commit into from Nov 17, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Nov 17, 2023

Resolves #3763

Fixes a bug with:

dataset.merge_samples(samples, key_field=key_field, ...)

when dataset is a grouped dataset, samples is a list of samples, and a key_field is provided.

@brimoor brimoor added the bug Bug fixes label Nov 17, 2023
@brimoor brimoor requested a review from a team November 17, 2023 14:36
@brimoor brimoor self-assigned this Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1646 lines in your changes are missing coverage. Please review.

Comparison is base (e0e6505) 15.57% compared to head (609d333) 15.41%.
Report is 25 commits behind head on develop.

Files Patch % Lines
...rc/components/ColorModal/controls/IdxColorList.tsx 0.00% 262 Missing ⚠️
app/packages/core/src/components/Starter/index.tsx 0.00% 243 Missing ⚠️
...nents/ColorModal/colorPalette/FieldsMaskTarget.tsx 0.00% 95 Missing ⚠️
...nts/ColorModal/colorPalette/DefaultMaskTargets.tsx 0.00% 92 Missing ⚠️
.../src/plugins/SchemaIO/components/LazyFieldView.tsx 0.00% 92 Missing ⚠️
...es/core/src/components/ColorModal/FieldSetting.tsx 0.00% 83 Missing ⚠️
app/packages/core/src/components/Common/Input.tsx 0.00% 83 Missing ⚠️
...pp/packages/core/src/components/Starter/content.ts 0.00% 75 Missing ⚠️
app/packages/operators/src/state.ts 0.00% 70 Missing ⚠️
app/packages/operators/src/hooks.ts 0.00% 69 Missing ⚠️
... and 32 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3816      +/-   ##
===========================================
- Coverage    15.57%   15.41%   -0.17%     
===========================================
  Files          645      657      +12     
  Lines        74120    75560    +1440     
  Branches       990     1000      +10     
===========================================
+ Hits         11542    11644     +102     
- Misses       62578    63916    +1338     
Flag Coverage Δ
app 15.41% <6.05%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and works as expected in the original issue.

@brimoor brimoor merged commit 85c6f0e into develop Nov 17, 2023
6 of 9 checks passed
@brimoor brimoor deleted the bugfix/iss-3763 branch November 17, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cause data duplicated when merging grouped samples and using key_fcn.
2 participants