Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SchemaIO exception when onChange is missing #3840

Merged
merged 1 commit into from Nov 27, 2023

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Nov 27, 2023

What changes are proposed in this pull request?

Fixes an exception in SchemaIO when onChange is not provided. Regressed in #3833

How is this patch tested? If it is not, please explain why.

Using OperatorIO debugging panel

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.23.0@3738536). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.23.0    #3840   +/-   ##
==================================================
  Coverage                   ?   15.65%           
==================================================
  Files                      ?      728           
  Lines                      ?    80534           
  Branches                   ?     1074           
==================================================
  Hits                       ?    12609           
  Misses                     ?    67925           
  Partials                   ?        0           
Flag Coverage Δ
app 15.65% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imanjra imanjra merged commit b9174c7 into release/v0.23.0 Nov 27, 2023
13 checks passed
@imanjra imanjra deleted the bugfix/schmeaio-no-onchange branch November 27, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants