Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Take seed in App #3855

Merged
merged 2 commits into from Dec 1, 2023
Merged

Fix Take seed in App #3855

merged 2 commits into from Dec 1, 2023

Conversation

benjaminpkane
Copy link
Contributor

Fixes Take seed changes in the App.

Changes

  • Fix comma handling
  • Process view changes from the bar and exclude _rand kwarg when seed changes
Screen.Recording.2023-11-30.at.3.45.37.PM.mov
Screen.Recording.2023-11-30.at.3.44.38.PM.mov

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Nov 30, 2023
@benjaminpkane benjaminpkane self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 185 lines in your changes are missing coverage. Please review.

Comparison is base (0b010e9) 15.57% compared to head (c49d413) 15.55%.
Report is 3 commits behind head on release/v0.23.0.

Files Patch % Lines
...nents/ColorModal/colorPalette/GlobalColorscale.tsx 0.00% 52 Missing ⚠️
.../components/ColorModal/colorPalette/Colorscale.tsx 0.00% 42 Missing ⚠️
app/packages/state/src/recoil/view.ts 6.45% 29 Missing ⚠️
app/packages/relay/src/graphQLSyncFragmentAtom.ts 5.26% 18 Missing ⚠️
...ackages/relay/src/graphQLSyncFragmentAtomFamily.ts 0.00% 18 Missing ⚠️
...ges/core/src/components/ColorModal/ColorFooter.tsx 0.00% 11 Missing ⚠️
...nts/ViewBar/ViewStage/viewStageParameterMachine.ts 0.00% 6 Missing ⚠️
...s/core/src/components/ColorModal/ShareStyledDiv.ts 0.00% 5 Missing ⚠️
app/packages/core/src/utils/links.ts 0.00% 2 Missing ⚠️
.../components/ColorModal/controls/ColorAttribute.tsx 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.23.0    #3855      +/-   ##
===================================================
- Coverage            15.57%   15.55%   -0.02%     
===================================================
  Files                  729      729              
  Lines                80998    81401     +403     
  Branches              1075     1085      +10     
===================================================
+ Hits                 12615    12665      +50     
- Misses               68383    68736     +353     
Flag Coverage Δ
app 15.55% <5.61%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@manivoxel51 manivoxel51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🍨

@benjaminpkane benjaminpkane merged commit 0a3e667 into release/v0.23.0 Dec 1, 2023
13 checks passed
@benjaminpkane benjaminpkane deleted the bug/app-take branch December 1, 2023 18:04
kaixi-wang pushed a commit that referenced this pull request Dec 5, 2023
* fix take

* comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants