Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: tag labels in multiple samples can only tag labels in the last sample successfully #3858

Merged
merged 1 commit into from Dec 1, 2023

Conversation

lanzhenw
Copy link
Contributor

@lanzhenw lanzhenw commented Dec 1, 2023

What changes are proposed in this pull request?

As a user, when I go to the modal view, select labels and go to the next sample and select more labels, and tag labels, only labels from the last sample get actually tagged.

This PR fixed the regression described above.

How is this patch tested? If it is not, please explain why.

Screen.Recording.2023-12-01.at.12.14.22.AM.mov

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@lanzhenw lanzhenw added the bug Bug fixes label Dec 1, 2023
@lanzhenw lanzhenw self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 528 lines in your changes are missing coverage. Please review.

Comparison is base (db73ce1) 15.56% compared to head (324f875) 15.56%.
Report is 8 commits behind head on release/v0.23.0.

Files Patch % Lines
...p/packages/core/src/components/Actions/Options.tsx 0.00% 117 Missing ⚠️
...nents/ColorModal/colorPalette/GlobalColorscale.tsx 0.00% 52 Missing ⚠️
.../components/ColorModal/colorPalette/Colorscale.tsx 0.00% 42 Missing ⚠️
...nents/Sidebar/Entries/FilterablePathEntry/state.ts 0.00% 38 Missing ⚠️
...src/components/Filters/StringFilter/Checkboxes.tsx 0.00% 26 Missing ⚠️
.../Filters/NumericFieldFilter/NumericFieldFilter.tsx 0.00% 22 Missing ⚠️
...ents/Sidebar/Entries/FilterablePathEntry/Arrow.tsx 0.00% 21 Missing ⚠️
app/packages/relay/src/graphQLSyncFragmentAtom.ts 0.00% 18 Missing ⚠️
...ackages/relay/src/graphQLSyncFragmentAtomFamily.ts 0.00% 18 Missing ⚠️
...erablePathEntry/LightningFilterablePathEntries.tsx 0.00% 17 Missing ⚠️
... and 31 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.23.0    #3858      +/-   ##
===================================================
- Coverage            15.56%   15.56%   -0.01%     
===================================================
  Files                  729      729              
  Lines                81365    81368       +3     
  Branches              1085     1085              
===================================================
  Hits                 12661    12661              
- Misses               68704    68707       +3     
Flag Coverage Δ
app 15.56% <11.40%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lanzhenw lanzhenw merged commit c15d175 into release/v0.23.0 Dec 1, 2023
13 checks passed
@lanzhenw lanzhenw deleted the bugfix/tagging branch December 1, 2023 17:17
kaixi-wang pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants