Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Orthographic projection #3864

Merged
merged 1 commit into from Dec 1, 2023

Conversation

sashankaryal
Copy link
Contributor

What changes are proposed in this pull request?

This PR fixes a bug where orthographic projections weren't showing because sampleMediaFilePath was being set after sample config was already instantiated.

Screenshot 2023-12-01 at 10 18 31 PM

@sashankaryal sashankaryal changed the base branch from develop to release/v0.23.0 December 1, 2023 19:21
@sashankaryal sashankaryal self-assigned this Dec 1, 2023
@sashankaryal sashankaryal requested a review from a team December 1, 2023 19:22
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! LGTM!

@benjaminpkane benjaminpkane merged commit 5ce370f into release/v0.23.0 Dec 1, 2023
@benjaminpkane benjaminpkane deleted the bugfix/orthographic-projection branch December 1, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants