Fixing bug when inferring doubly-nested dynamic list field types #3900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.1 #3900 +/- ##
================================================
Coverage 15.86% 15.86%
================================================
Files 731 731
Lines 81544 81544
Branches 1093 1093
================================================
Hits 12936 12936
Misses 68608 68608
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benjaminpkane
approved these changes
Dec 8, 2023
swheaton
reviewed
Dec 8, 2023
Comment on lines
1331
to
+1339
| if is_list_field and not _path.endswith("[]"): | ||
| _path += "[]" | ||
|
|
||
| # Cache the manual unwind in case we need it recursively | ||
| # Insert rather than append so that nested paths are found | ||
| # first when using this cache | ||
| _clean_path = _path.replace("[]", "") | ||
| unwind_cache.insert(0, (_clean_path, _path)) | ||
|
|
There was a problem hiding this comment.
I do not entirely understand what's going on here so just making sure it's intentional that this logic only applies when _path.endswith("[]") is False
There was a problem hiding this comment.
Yeah this is correct as written. The only way that [] gets into the path is inside this if, which is the time when we need to cache an undeclared list field that we've found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a very subtle issue when inferring dynamic schemas for doubly-nested list fields. The new unit test fails on
developbut passes on this branch.