show primitive in embedded document in ListField #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.3 #3963 +/- ##
===================================================
- Coverage 15.86% 15.86% -0.01%
===================================================
Files 731 731
Lines 81853 81882 +29
Branches 1093 1093
===================================================
+ Hits 12987 12988 +1
- Misses 68866 68894 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
benjaminpkane
previously approved these changes
Jan 4, 2024
manivoxel51
previously approved these changes
Jan 4, 2024
| const pinned3DSample = useRecoilValue(fos.pinned3DSampleSlice); | ||
| const activePcdSlices = useRecoilValue(fos.activePcdSlices); | ||
| const slices = Boolean(pinned3DSample) && (activePcdSlices?.length || 1) > 1; | ||
|
|
||
| return field && field.ftype !== LIST_FIELD ? ( | ||
| const isScalar = useRecoilValue(isScalarValue(path)); | ||
| console.log(path, isScalar); |
benjaminpkane
dismissed stale reviews from manivoxel51 and themself
via
c1af0ad
|
Nice! Thank you @benjaminpkane and @manivoxel51! 🚀 |
brimoor
pushed a commit
that referenced
this pull request
Jan 10, 2024
* show primitive in embedded document in ListField * use ListValueEntry for consistency * lint * log --------- Co-authored-by: Benjamin Kane <ben@voxel51.com>
brimoor
pushed a commit
that referenced
this pull request
Jan 15, 2024
* show primitive in embedded document in ListField * use ListValueEntry for consistency * lint * log --------- Co-authored-by: Benjamin Kane <ben@voxel51.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes an issue where primitive values in DynamicEmbeddedDocument within ListField is displayed as
Nonesample modalHow is this patch tested? If it is not, please explain why.
Verified values are displayed as CSV in the sample modal for the embedded fields:
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
Primitive values in DynamicEmbeddedDocument within ListField will be displayed as comma separated values (previously, displayed as
None) in the sample modalWhat areas of FiftyOne does this PR affect?
fiftyonePython library changes