Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excluding 10 from zero-padding #4035

Merged
merged 1 commit into from Jan 26, 2024

Conversation

nebulae
Copy link
Contributor

@nebulae nebulae commented Jan 23, 2024

What changes are proposed in this pull request?

not "0" left padding the number 10, to avoid "0.010" after "0.9" and before "0.11"

How is this patch tested? If it is not, please explain why.

by rewatching the videos for more than 9 seconds

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.23.4@112e8ba). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.23.4    #4035   +/-   ##
==================================================
  Coverage                   ?   15.98%           
==================================================
  Files                      ?      732           
  Lines                      ?    81965           
  Branches                   ?     1101           
==================================================
  Hits                       ?    13100           
  Misses                     ?    68865           
  Partials                   ?        0           
Flag Coverage Δ
app 15.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benjaminpkane
benjaminpkane previously approved these changes Jan 24, 2024
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! LGTM ⏲️

Base automatically changed from release/v0.23.4 to main January 25, 2024 23:27
@benjaminpkane benjaminpkane changed the base branch from main to release/v0.23.5 January 26, 2024 20:42
@benjaminpkane benjaminpkane dismissed their stale review January 26, 2024 20:42

The base branch was changed.

@benjaminpkane benjaminpkane merged commit e67cc45 into release/v0.23.5 Jan 26, 2024
12 of 13 checks passed
@benjaminpkane benjaminpkane deleted the trinity/v0.23.4/unpadded_10_fix branch January 26, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants