Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffle Stage Random Number Bug #4052

Merged
merged 1 commit into from Jan 30, 2024
Merged

Conversation

geke-mir
Copy link
Contributor

What changes are proposed in this pull request?

Cast floats to ints to fix #4051

How is this patch tested? If it is not, please explain why.

Verified that the bug in #4051 has been resolved with updated source. I could not find existing test code for stages.py, would be happy to amend this PR to begin them.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor
Copy link
Contributor

brimoor commented Jan 30, 2024

@geke-mir thanks for fixing this! Must be a breaking change in newer versions of python and/or specifically the random core package (Shuffle()'s implementation hasn't changed in quite awhile)

There are tests that involve the shuffle() stage in https://github.com/voxel51/fiftyone/blob/develop/tests/unittests/view_tests.py, so I think we're all set here.

@brimoor brimoor merged commit a626f1e into voxel51:develop Jan 30, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Shuffle Stage Random Number Bug
2 participants