Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch fix for zero-shot detection batching #4108

Merged
merged 1 commit into from Feb 27, 2024

Conversation

jacobmarks
Copy link
Contributor

Zero-shot object detection transformers used for batch inference had shape mismatch issue. This reverts to naive implementation, just for zero-shot object detection transformers.

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.99%. Comparing base (135acd1) to head (dca27c1).
Report is 8 commits behind head on release/v0.23.6.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.23.6    #4108   +/-   ##
================================================
  Coverage            15.99%   15.99%           
================================================
  Files                  732      732           
  Lines                82062    82062           
  Branches              1110     1110           
================================================
  Hits                 13123    13123           
  Misses               68939    68939           
Flag Coverage Δ
app 15.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobmarks jacobmarks merged commit db89ae9 into release/v0.23.6 Feb 27, 2024
9 checks passed
@jacobmarks jacobmarks deleted the jacobmarks-patch-1 branch February 27, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants