Use estimated dataset count for index page query #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4114 +/- ##
========================================
Coverage 28.84% 28.85%
========================================
Files 768 769 +1
Lines 97035 97127 +92
Branches 1120 1128 +8
========================================
+ Hits 27991 28026 +35
- Misses 69044 69101 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imanjra
reviewed
Mar 21, 2024
| allDatasets: datasets(search: "") { | ||
| total | ||
| } | ||
| allDatasets: estimatedDatasetCount |
There was a problem hiding this comment.
do we also need to update line 29 of this file? Or will it work as is?
There was a problem hiding this comment.
The name of the field is still aliased as allDatasets, I think it should work
There was a problem hiding this comment.
My mistake, total is missing now 👍
imanjra
approved these changes
Mar 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Replaces the
datasets(search: "")field query for the index page with an optimized estimated dataset count. The current approach is potentially very slow for a database with a large number of datasets.How is this patch tested? If it is not, please explain why.
e2e coverage
Release Notes
What areas of FiftyOne does this PR affect?
fiftyonePython library changes