New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for setting saved view in set-view operator #4159
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.7 #4159 +/- ##
===================================================
- Coverage 16.03% 16.00% -0.04%
===================================================
Files 733 734 +1
Lines 82012 82229 +217
Branches 1118 1119 +1
===================================================
+ Hits 13153 13159 +6
- Misses 68859 69070 +211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🍨
I didn't pull and test this one. curious if the URL slug also changes when setting view name? 🤔
if (params.view) { | ||
hooks.setView(params.view); | ||
} else if (params.name) { | ||
hooks.setViewName(params.name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! does the order matter?
example: you have set a view (skip-10) and then try to load by name. will this work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order indeed introduces some precedence. I.e. if you execute this operator with both the view
and name
param, the view
will take precedence. If you execute this operator multiple times, the most recent will be the final result.
Thanks @manivoxel51! Yes, the URL slug as well as the saved view dropdown selected state changes when this operator is invoked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imanjra can you target this at release/v0.23.7
instead so we can release it on Wednesday? 😄
b3cdf12
to
d1864ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes are proposed in this pull request?
add support for setting a saved view with the
set_view
built-in operatorUsage: setting a view using the name of a saved view
How is this patch tested? If it is not, please explain why.
Using an example operator with a snippet above
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
add support for setting a saved view with the
set_view
built-in operatorWhat areas of FiftyOne does this PR affect?
fiftyone
Python library changes