Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading YOLOv8 and YOLOv9 Segmentation Models from Zoo #4220

Merged
merged 4 commits into from Apr 3, 2024

Conversation

jacobmarks
Copy link
Contributor

@jacobmarks jacobmarks commented Apr 2, 2024

Builds off of the existing Ultralytics integration, which allowed for:

  • applying YOLO detection, pose estimation, or instance segmentation models to FiftyOne sample collections, and
  • loading YOLO detection models directly from the FiftyOne model zoo

Now, you can load YOLOv8 segmentation models and YOLOv9 segmentation models directly from the FiftyOne Model Zoo with:

import fiftyone as fo
import fiftyone.zoo as foz

model_name = "yolov9c-seg-coco-torch"
# model_name = "yolov9e-seg-coco-torch"
# model_name = "yolov8x-seg-coco-torch"
# model_name = "yolov8l-seg-coco-torch"
# model_name = "yolov8m-seg-coco-torch"
# model_name = "yolov8s-seg-coco-torch"
# model_name = "yolov8n-seg-coco-torch"

model = foz.load_zoo_model(model_name, label_field="yolo_seg")

dataset.apply_model(model)

session = fo.launch_app(dataset)

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Summary by CodeRabbit

  • Documentation
    • Enhanced the Ultralytics integration guide with examples on loading YOLOv8 and YOLOv9 models for dataset segmentation.

@jacobmarks jacobmarks requested a review from brimoor April 2, 2024 18:22
Copy link
Contributor

coderabbitai bot commented Apr 2, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • fiftyone/zoo/models/manifest-torch.json is excluded by !**/*.json

Walkthrough

The recent update introduces code examples for loading YOLOv8 and YOLOv9 segmentation models from the FiftyOne Model Zoo and applying them to datasets. This enhancement is documented in the Ultralytics integration section, facilitating users in leveraging advanced YOLO models for their segmentation tasks.

Changes

File Path Change Summary
docs/source/.../ultralytics.rst Added examples for loading YOLOv8 and YOLOv9 models and applying them to datasets.

Possibly related issues

Poem

In the land of code and byte,
Where models dwell in the night,
Came YOLOv8 and nine, so bright,
To aid our vision, enhance our sight.
🐇 With every pixel, clear and right,
We celebrate this leap in might!

((\
(-.-)
o_(")(")

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.56%. Comparing base (02c4d49) to head (d333740).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4220       +/-   ##
============================================
- Coverage    27.99%   15.56%   -12.44%     
============================================
  Files          814      779       -35     
  Lines       101631    86536    -15095     
  Branches      1178     1178               
============================================
- Hits         28453    13467    -14986     
+ Misses       73178    73069      -109     
Flag Coverage Δ
app 15.56% <ø> (+<0.01%) ⬆️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between e53596a and 6f9b4e6.
Files ignored due to path filters (1)
  • fiftyone/zoo/models/manifest-torch.json is excluded by !**/*.json
Files selected for processing (1)
  • docs/source/integrations/ultralytics.rst (1 hunks)
Additional comments not posted (1)
docs/source/integrations/ultralytics.rst (1)

172-191: The addition of code snippets for loading YOLOv8 and YOLOv9 segmentation models from the FiftyOne Model Zoo is clear and follows the established documentation pattern. Ensure that the model names mentioned (e.g., "yolov9c-seg-coco-torch", "yolov9e-seg-coco-torch") are available and correctly named in the FiftyOne Model Zoo.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@jacobmarks jacobmarks merged commit 8331d26 into develop Apr 3, 2024
10 checks passed
@jacobmarks jacobmarks deleted the yolov9-seg branch April 3, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants