-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
heatmap on click #4343
heatmap on click #4343
Conversation
WalkthroughThe recent updates to the software focus on enhancing visualization capabilities in Changes
Recent Review DetailsConfiguration used: .coderabbit.yaml Files ignored due to path filters (2)
Files selected for processing (3)
Additional Context UsedRuff (2)
Path-based Instructions (2)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
@@ -78,6 +78,7 @@ export function CustomPanel(props: CustomPanelProps) { | |||
layout={{ height, width }} | |||
onPathChange={handlePanelStatePathChange} | |||
/> | |||
<pre>{JSON.stringify(data, null, 2)}</pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the implications of displaying raw data in the UI.
Exposing raw data within the UI can lead to unintentional leakage of sensitive information, especially if this component is used in a production environment. If this feature is intended for debugging purposes, consider adding a condition to render this component only in development mode or ensure that the data displayed does not contain sensitive information.
panel_id = ctx.params.get("panel_id", None) | ||
method_name = ctx.params.get("__method__", None) | ||
state = ctx.params.get("state", {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused local variables in the execute
method.
The variables panel_id
and state
are assigned values but are never used within the execute
method. This could indicate an oversight or incomplete refactoring. Consider removing these variables if they are not needed, or ensure that their intended use is implemented correctly.
@@ -107,6 +113,8 @@ export default function PlotlyView(props) { | |||
const mergedConfig = merge({}, configDefaults, config); | |||
const mergedData = mergeData(data, dataDefaults); | |||
|
|||
console.log(mergedLayout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✂️
@@ -78,6 +78,7 @@ export function CustomPanel(props: CustomPanelProps) { | |||
layout={{ height, width }} | |||
onPathChange={handlePanelStatePathChange} | |||
/> | |||
<pre>{JSON.stringify(data, null, 2)}</pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✂️
Summary by CodeRabbit
New Features
PlotlyView
component to support various plot types including histograms, scatter plots, bar plots, and heatmaps.Refactor
PlotlyView
for dynamic range calculations based on selected plot type.PlotlyView
to dynamically setx
andy
values.Style
CustomPanel
component.Chores
PanelOperator
class to clean up the logging output.