fix: tests

voxmedia · Mar 1, 2021 · fb9e08e · fb9e08e
1 parent 5b9e614
commit fb9e08e
Show file tree

Hide file tree

Showing 4 changed files with 4,373 additions and 752 deletions.
diff --git a/__tests__/utils.spec.js b/__tests__/utils.spec.js
@@ -33,9 +33,19 @@ describe('Utils', () => {
       it('links to the action workflow', () => {
         const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PUSH_EVENT });
 
-        expect(attachments[0].fields.find(a => a.title === 'Action')).toEqual({
-          title: 'Action',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/commit/abc123/checks | CI>`,
+        expect(attachments[0].fields.find(a => a.title === 'Workflow')).toEqual({
+          title: 'Workflow',
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/12345 | CI>`,
+          short: true,
+        });
+      });
+
+      it('links to the action job', () => {
+        const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PUSH_EVENT });
+
+        expect(attachments[0].fields.find(a => a.title === 'Job')).toEqual({
+          title: 'Workflow',
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/12345 | build and push>`,
           short: true,
         });
       });
@@ -65,9 +75,9 @@ describe('Utils', () => {
       it('links to the action workflow', () => {
         const attachments = buildSlackAttachments({ status: 'STARTED', color: 'good', github: GITHUB_PR_EVENT });
 
-        expect(attachments[0].fields.find(a => a.title === 'Action')).toEqual({
-          title: 'Action',
-          value: `<https://github.com/voxmedia/github-action-slack-notify-build/commit/xyz678/checks | CI>`,
+        expect(attachments[0].fields.find(a => a.title === 'Workflow')).toEqual({
+          title: 'Workflow',
+          value: `<https://github.com/voxmedia/github-action-slack-notify-build/actions/runs/12345 | CI>`,
           short: true,
         });
       });

diff --git a/dist/index.js b/dist/index.js
diff --git a/fixtures.js b/fixtures.js
@@ -14,8 +14,8 @@ export const GITHUB_PUSH_EVENT = {
     workflow: 'CI',
     eventName: 'push',
     sha: 'abc123',
-    job: 'ci',
-    runId: 12345
+    job: 'build and push',
+    runId: 12345,
   },
 };
 
@@ -35,7 +35,7 @@ export const GITHUB_PR_EVENT = {
     workflow: 'CI',
     eventName: 'pull_request',
     sha: 'abc123',
-    job: 'ci',
-    runId: 12345
+    job: 'build and push',
+    runId: 12345,
   },
 };
diff --git a/src/utils.js b/src/utils.js
@@ -27,12 +27,12 @@ function buildSlackAttachments({ status, color, github }) {
       fields: [
         {
           title: 'Workflow',
-          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId}/ | ${workflow}>`,
+          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${workflow}>`,
           short: true,
         },
         {
           title: 'Job',
-          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId}/ | ${job}>`,
+          value: `<https://github.com/${owner}/${repo}/actions/runs/${runId} | ${job}>`,
           short: true,
         },
         {