-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable file names and paths #6
Comments
@keithjgrant Some feedback: Regarding the use of Also: I would probably create a new method that could be used in both |
Adds new filenameStyle property. Change mentioned in #6
@keithjgrant I went ahead and added a simple mechanism for filenames, let me know any feedback you might have on it! |
That looks good. I'm trying to test integration with micropub-to-github... having some troubles though. Possible b/c I'm not too familiar with Heroku |
I've done some integration testing w/ my site. I added some changes to webpage-micropub-to-github to allow configuration of the filenameStyle (https://github.com/keithjgrant/webpage-micropub-to-github/commits/master), which is in turn passed into this lib as an option. I now have notes, replies, and likes working, each writing to their own respective directory (with matching permalinks). Not sure if there's more you have in mind for this ticket, but I think your changes support everything I need for my use case at this point. |
I will consider #7 as well before I close this, then I'll tag a version and update the |
As soon as this is tagged, I can submit a PR to webpage-micropub-to-github that has the integration setup (passing the config value into this lib) (see: commits on https://github.com/keithjgrant/webpage-micropub-to-github/commits/master from Feb 11) |
@keithjgrant Sorry for not having responded! The last two months has for a variety of reasons not seen a lot of time for open source work. I'll try to make a release asap. |
Tagged and released as Closing this issue as fixed. Once again: Sorry for the delay! |
Splitting this up from #5 to keep the discussions around this in one place as it's probably the major change needed to fully support Hugo, the rest of the changes in #5 are fairly minor.
As stated in #5 this is fairly similar to voxpelli/webpage-micropub-to-github#8 and could probably use the same mechanism for both.
@keithjgrant added some comments: #5 (comment)
The text was updated successfully, but these errors were encountered: