Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options.author #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

revolunet
Copy link

@revolunet revolunet commented Jan 3, 2020

馃憢 Add support for options.author :

publisher.publish("log-YYMMAA", logContent, {
  message: 'some commit message',
  author: {
    name: 'Clint',
    email: 'clint@someone.com'
  }
})

@revolunet
Copy link
Author

Hi @voxpelli, any chance this can be merged ?

@voxpelli
Copy link
Owner

Yes, absolutely, sorry for delay

@voxpelli
Copy link
Owner

I think I would prefer to not just forward the author option but to actually pick the specific properties from it and just forward those. Then the API of this module doesn鈥檛 become coupled with the API of GitHub and accidental submits of extra data becomes impossible (if eg. one adds an object which implements author fields but also lots of other fields)

@revolunet
Copy link
Author

Ok, i'm not sure ive understood correctly but heres a fix to only pick name and email

@revolunet
Copy link
Author

Bump 馃榿

Base automatically changed from master to main January 25, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants