feat(main): allow retries to be limited

[oliversalzburg]

No description provided.

[oliversalzburg]

Working on fixing the coverage. I already noticed problems as well. Will post an update soon.

[oliversalzburg]

@voxpelli I think I need your help. husky prevents me from pushing, because jshint doesn't like the .jshintrc:

Running "lintspaces:files" (lintspaces) task
>> 3 lint free.

Running "jshint:files" (jshint) task
ERROR: Can't parse config file: .jshintrc
Error:SyntaxError: Unexpected token o

[oliversalzburg]

Ah, got that solved. Those are supposed to be symlinks. Now it fails at a different spot:

Running "dependency-check:files" (dependency-check) task
Fatal error: Object.keys called on non-object

[oliversalzburg]

I pushed with --no-verfiy tests are passing now. I would appreciate if you could have a look at everything. I'm not sure I fully understood the tests.

Let me know if I need to fix anything :)

[voxpelli]

@oliversalzburg Sorry for the dependency-check failure – I'm co-maintaining that module so would like to try and find out what the error was. Which Node are you running? Some 0.12 version r an io.js version?

[voxpelli]

Would prefer if the default was either false or undefined – more explicit about the intention of the value

[oliversalzburg]

@voxpelli I'm on 0.12.7 on Windows 10

[oliversalzburg]

@voxpelli Thanks for the review. New version is up :)

[voxpelli]

Looks like the dependency-check issue has been reported: dependency-check-team/dependency-check#30

[voxpelli]

This check also needs to be updated now that the default has changed

[oliversalzburg]

Jeeze, it's getting late :P Sorry for missing that.

[oliversalzburg]

Very cool :) I'll start working on voxpelli/node-pg-pubsub#6 again tomorrow at work. Thanks for the help!

[voxpelli]

Published as 0.2.3 – extended the tests a bit and as the result of that changed the code a bit as well. Also removed the .end() – not needed and slipped through my first review :)

[oliversalzburg]

Interesting. I didn't understand the difference between end()ing and plain stopping :\

[voxpelli]

Ending is for graceful and immediate shutdowns of applications, to ensure that no matter what happens nothing, not even a reset, will try to establish a new connection :)