Don't set container name to node hostname

This prevents running beaker concurrently with other beaker nodesets containing nodes with the same hostname.
voxpupuli · Sep 28, 2017 · dcb70a2 · dcb70a2
1 parent 2458a36
commit dcb70a2
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/lib/beaker/hypervisor/docker.rb b/lib/beaker/hypervisor/docker.rb
@@ -70,7 +70,6 @@ def provision
         container_opts = {
           'Image' => image_name,
           'Hostname' => host.name,
-          'name' => host.name,
           'HostConfig' => {
             'PortBindings' => {
               '22/tcp' => [{ 'HostPort' => rand.to_s[2..5], 'HostIp' => '0.0.0.0'}]

diff --git a/spec/beaker/hypervisor/docker_spec.rb b/spec/beaker/hypervisor/docker_spec.rb
@@ -181,7 +181,6 @@ module Beaker
           expect( ::Docker::Container ).to receive(:create).with({
             'Image' => image.id,
             'Hostname' => host.name,
-            'name' => host.name,
             'HostConfig' => {
               'PortBindings' => {
                 '22/tcp' => [{ 'HostPort' => /\b\d{4}\b/, 'HostIp' => '0.0.0.0'}]
@@ -211,7 +210,6 @@ module Beaker
           expect( ::Docker::Container ).to receive(:create).with({
             'Image' => image.id,
             'Hostname' => host.name,
-            'name' => host.name,
             'HostConfig' => {
               'PortBindings' => {
                 '22/tcp' => [{ 'HostPort' => /\b\d{4}\b/, 'HostIp' => '0.0.0.0'}]
@@ -284,7 +282,6 @@ module Beaker
           expect( ::Docker::Container ).to receive(:create).with({
             'Image' => image.id,
             'Hostname' => host.name,
-            'name' => host.name,
             'HostConfig' => {
               'Binds' => [
                 '/source_folder:/mount_point',