Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop beaker-rspec dependency #107

Merged
merged 1 commit into from
Mar 26, 2023
Merged

Drop beaker-rspec dependency #107

merged 1 commit into from
Mar 26, 2023

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Mar 25, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3806f04) 85.96% compared to head (8ff025f) 85.96%.

❗ Current head 8ff025f differs from pull request most recent head 8fb2ab9. Consider uploading reports for the commit 8fb2ab9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files           1        1           
  Lines         285      285           
=======================================
  Hits          245      245           
  Misses         40       40           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jay7x jay7x marked this pull request as draft March 25, 2023 14:40
@jay7x
Copy link
Member Author

jay7x commented Mar 25, 2023

Drafted to merge after dropping old rubies

@bastelfreak
Copy link
Member

This requires beaker 4 which requires Ruby >= 2.7

@jay7x
Copy link
Member Author

jay7x commented Mar 26, 2023

This requires beaker 4 which requires Ruby >= 2.7

Yep, so it seems this should be merged after bumping the Ruby requirements.

@bastelfreak bastelfreak changed the title Drop beaker-rspec (not really used) Drop beaker-rspec Mar 26, 2023
@bastelfreak bastelfreak changed the title Drop beaker-rspec Drop beaker-rspec dependency Mar 26, 2023
@bastelfreak bastelfreak marked this pull request as ready for review March 26, 2023 19:00
@bastelfreak bastelfreak self-assigned this Mar 26, 2023
@bastelfreak bastelfreak merged commit 26ad21c into voxpupuli:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants