Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BKR-1586 - allow an 'as-is' container to be used rather than rebuilding every time #17

Merged
merged 2 commits into from
May 6, 2019

Conversation

oldNoakes
Copy link
Contributor

As per https://tickets.puppetlabs.com/browse/BKR-1586 this change allows a new flag to be defined for the docker hypervisor use_image_as_is which will cause the provision step of the process to simply pull the image down and use it without rebuilding it.

This pushes the responsibility for setting up a root:root ssh process on the container onto the user but has the benefit of speeding up test time by only having to do a docker pull rather than a docker build

@puppetlabs-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@smcelmurry
Copy link
Contributor

test this please

@smcelmurry smcelmurry merged commit d1fffa2 into voxpupuli:master May 6, 2019
@oldNoakes
Copy link
Contributor Author

Hey @smcelmurry - did you need further tests for this (is merged though) - didn't add a functional test as all the containers I could find that had the root:root password pre-built were generally user builds rather than any official builds and didn't seem like a good idea to add as a test - can publish a container with this setup if needed.

Thanks.

@oldNoakes
Copy link
Contributor Author

Also thanks :) - this is speeding up our build times by about 70%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants