Remove beaker from Gemfile #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 84.00% 84.00%
=======================================
Files 1 1
Lines 300 300
=======================================
Hits 252 252
Misses 48 48 Continue to review full report at Codecov.
|
ekohl
reviewed
Feb 11, 2022
| # We don't put beaker in as a test dependency because we | ||
| # don't want to create a transitive dependency | ||
| group :acceptance_testing do | ||
| gem "beaker", *location_for(ENV['BEAKER_VERSION'] || '>= 4.30') |
There was a problem hiding this comment.
This is the only use of location_for. If you drop it here, you might as well drop it from Gemfile altogether
we already pull it in via beaker-docker.gemspec.
ekohl
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already pull it in via beaker-docker.gemspec.