Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker hostfile parameter docker_image_first_commands #65

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

Rathios
Copy link
Contributor

@Rathios Rathios commented Aug 10, 2022

Adds a Docker hostfile parameter docker_image_first_commands which allows inserting RUN commands at the very top of the Dockerfile. This allows proxy configuration for apt/yum/dnf.

docker_image_commands does not work for this as it's commands are inserted too late to configure proxy for all package manager commands.

Thank you for considering. I am behind a proxy at my company and this makes testing a bit easier for me as we don't currently have a direct-to-internet environment for development.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #65 (930a21d) into master (11b13f6) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 930a21d differs from pull request most recent head a9c6720. Consider uploading reports for the commit a9c6720 to get more accurate results

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   84.00%   84.10%   +0.10%     
==========================================
  Files           1        1              
  Lines         300      302       +2     
==========================================
+ Hits          252      254       +2     
  Misses         48       48              
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 84.10% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Rathios Rathios changed the title Add Dockerfile parameter docker_image_first_commands Add Docker hostfile parameter docker_image_first_commands Aug 10, 2022
@Rathios Rathios force-pushed the docker_image_first_commands branch from d9bc749 to 2f25be2 Compare August 10, 2022 08:24
@Rathios Rathios force-pushed the docker_image_first_commands branch from 2f25be2 to a9c6720 Compare August 10, 2022 09:02
@bastelfreak bastelfreak reopened this Aug 10, 2022
@bastelfreak bastelfreak merged commit e12dd04 into voxpupuli:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants