Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor built-in Dockerfile and fix_ssh() #71

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Refactor built-in Dockerfile and fix_ssh() #71

merged 1 commit into from
Dec 21, 2022

Conversation

jay7x
Copy link
Member

@jay7x jay7x commented Dec 20, 2022

Changes:

  • Reduce layers amount in the image generated from the built-in Dockerilfe (every RUN produces another layer)
  • Squash multiple sed invocations into one
  • Sync sshd_config changes in the built-in Dockerfile and in the fix_ssh() function.
  • Improve ssh service name detection in fix_ssh()
  • Implement some rubocop suggestions
  • Remove unused sshd_options variable

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 84.05% // Head: 84.74% // Increases project coverage by +0.69% 🎉

Coverage data is based on head (8cca573) compared to base (c35798f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   84.05%   84.74%   +0.69%     
==========================================
  Files           1        1              
  Lines         301      295       -6     
==========================================
- Hits          253      250       -3     
+ Misses         48       45       -3     
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 84.74% <100.00%> (+0.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jay7x
Copy link
Member Author

jay7x commented Dec 20, 2022

I'd like to refactor a bit more here.. e.g. stop duplicating parts in dockerfile_for(), install_ssh_components(), fix_ssh(). So consider this as 1st PR of a series.

Changes:
* Reduce layers amount in the image generated from the built-in
  Dockerilfe (every RUN produces another layer)
* Squash multiple sed invocations into one
* Sync sshd_config changes in the built-in Dockerfile and in the
  fix_ssh() function.
* Improve ssh service name detection in fix_ssh()
* Implement some rubocop suggestions
* Remove unused sshd_options variable
@bastelfreak bastelfreak merged commit f3bcdc3 into voxpupuli:master Dec 21, 2022
@jay7x jay7x deleted the less_layers branch December 21, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants