Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify port detection code #95

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 17, 2023

This saves a few redundant variable assignments.

This saves a few redundant variable assignments.
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.87 🎉

Comparison is base (9a4e935) 84.74% compared to head (37d3811) 85.61%.

❗ Current head 37d3811 differs from pull request most recent head 53efa23. Consider uploading reports for the commit 53efa23 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   84.74%   85.61%   +0.87%     
==========================================
  Files           1        1              
  Lines         295      292       -3     
==========================================
  Hits          250      250              
+ Misses         45       42       -3     
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 85.61% <0.00%> (+0.87%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak merged commit 77aab4d into voxpupuli:master Mar 17, 2023
@ekohl ekohl deleted the simplify-port-assignment branch March 17, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants