Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated genconfig2 script #269

Merged
merged 1 commit into from Feb 21, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 20, 2023

While the warning suggested it would be removed in 1.x, we're already at 1.12 so there should have been plenty of time.

While the warning suggested it would be removed in 1.x, we're already at
1.12 so there should have been plenty of time.
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 0.52% // Head: 0.50% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0cd16f1) compared to base (afd6f05).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 0cd16f1 differs from pull request most recent head 29b6d5a. Consider uploading reports for the commit 29b6d5a to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #269      +/-   ##
=========================================
- Coverage    0.52%   0.50%   -0.02%     
=========================================
  Files          14      15       +1     
  Lines        2485    2565      +80     
=========================================
  Hits           13      13              
- Misses       2472    2552      +80     
Impacted Files Coverage Δ
lib/beaker-hostgenerator/data.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/hypervisor.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/hypervisor/docker.rb 0.00% <0.00%> (ø)
lib/beaker-hostgenerator/hypervisor/hcloud.rb 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@bastelfreak
Copy link
Member

same as #236

@bastelfreak bastelfreak merged commit e913296 into voxpupuli:master Feb 21, 2023
@ekohl ekohl deleted the remove-genconfig2 branch February 21, 2023 19:28
@ekohl
Copy link
Member Author

ekohl commented Feb 21, 2023

I should have checked that before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants